Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when using unsupported sensors #1536

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Apr 9, 2024

Closes #1534

Here is how it currently looks:
image
If we want we can catch it in the frontend to make a more unique error for it.

@andchiind andchiind added feature New feature or request backend Backend related functionality labels Apr 9, 2024
@andchiind andchiind self-assigned this Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@andchiind andchiind force-pushed the 1534-not-supported branch from 9ad140d to 925cc2b Compare April 9, 2024 10:18
Copy link

github-actions bot commented Apr 9, 2024

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Apr 9, 2024
@andchiind andchiind force-pushed the 1534-not-supported branch from 925cc2b to 611f4d6 Compare April 9, 2024 10:27
@andchiind andchiind marked this pull request as ready for review April 9, 2024 10:27
@andchiind andchiind force-pushed the 1534-not-supported branch 3 times, most recently from 22ddaf5 to 9a209a7 Compare April 9, 2024 12:20
@andchiind andchiind removed the database-change Will require migration label Apr 9, 2024
@andchiind andchiind force-pushed the 1534-not-supported branch 2 times, most recently from 6f29674 to 3ad7403 Compare April 10, 2024 14:10
@andchiind andchiind requested a review from Christdej April 11, 2024 06:43
@andchiind andchiind force-pushed the 1534-not-supported branch from 3ad7403 to a5d7200 Compare April 12, 2024 13:28
@andchiind andchiind force-pushed the 1534-not-supported branch from a5d7200 to 8cedf79 Compare April 12, 2024 13:29
@andchiind andchiind requested a review from Christdej April 15, 2024 08:14
@andchiind andchiind merged commit 2136cdf into equinor:main Apr 15, 2024
11 checks passed
@andchiind andchiind deleted the 1534-not-supported branch April 15, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return an error when trying to start a mission containing tasks not supported by the given robot
2 participants