Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging who runs a robot mission (action log in flotilla) #1712

Merged
merged 9 commits into from
Aug 13, 2024

Conversation

betaniat
Copy link
Contributor

@betaniat betaniat commented Aug 7, 2024

Issue #1569, also linked to #1088

@betaniat betaniat self-assigned this Aug 7, 2024
@betaniat betaniat linked an issue Aug 8, 2024 that may be closed by this pull request
4 tasks
Copy link

github-actions bot commented Aug 9, 2024

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@betaniat betaniat force-pushed the issue_1569_new branch 3 times, most recently from e6e0f2a to bb21dcc Compare August 12, 2024 08:29
@betaniat betaniat marked this pull request as ready for review August 12, 2024 08:31
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. Remember to also rename the commit "Handling HTTPRequest exception" to something like "Handle HTTPRequest exception" to use the right verb form.

backend/api/Services/UserInfoServices.cs Outdated Show resolved Hide resolved
backend/api/Services/UserInfoServices.cs Outdated Show resolved Hide resolved
backend/api/Services/UserInfoServices.cs Outdated Show resolved Hide resolved
backend/api/Services/UserInfoServices.cs Outdated Show resolved Hide resolved
backend/api/Services/MissionRunService.cs Outdated Show resolved Hide resolved
backend/api/Database/Models/UserInfo.cs Outdated Show resolved Hide resolved
@betaniat betaniat force-pushed the issue_1569_new branch 2 times, most recently from 5e1d59b to f028596 Compare August 13, 2024 11:37
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Aug 13, 2024
@betaniat
Copy link
Contributor Author

/UpdateDatabase

Copy link

👀 Running migration command... 👀

Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/10369173268

Copy link

✨ Successfully ran migration command! ✨

@betaniat betaniat merged commit a812b77 into equinor:main Aug 13, 2024
12 checks passed
@betaniat betaniat deleted the issue_1569_new branch August 13, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database-change Will require migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider logging who runs a robot mission?
3 participants