Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isar steps in flotilla #1753

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Remove isar steps in flotilla #1753

merged 6 commits into from
Oct 17, 2024

Conversation

mrica-equinor
Copy link
Contributor

No description provided.

@mrica-equinor mrica-equinor changed the title WIP: Remove steps isar WIP: Remove steps isar on flotilla Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@mrica-equinor mrica-equinor force-pushed the remove-steps-isar branch 3 times, most recently from 9b24501 to 4ec9d69 Compare October 14, 2024 09:02
@mrica-equinor mrica-equinor changed the title WIP: Remove steps isar on flotilla Remove isar steps in flotilla Oct 14, 2024
@mrica-equinor mrica-equinor force-pushed the remove-steps-isar branch 2 times, most recently from a37fa77 to 8feb90d Compare October 14, 2024 11:25
@mrica-equinor mrica-equinor marked this pull request as ready for review October 14, 2024 11:29
andchiind
andchiind reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good otherwise

backend/api/Database/Models/Inspection.cs Outdated Show resolved Hide resolved
backend/api/Database/Models/MissionRun.cs Outdated Show resolved Hide resolved
backend/api/Database/Models/MissionTask.cs Outdated Show resolved Hide resolved
backend/api/Database/Models/MissionTask.cs Show resolved Hide resolved
backend/api/Database/Models/MissionTask.cs Outdated Show resolved Hide resolved
backend/api/Services/EchoService.cs Outdated Show resolved Hide resolved
backend/api/Services/EchoService.cs Outdated Show resolved Hide resolved
frontend/src/models/Inspection.ts Outdated Show resolved Hide resolved
@mrica-equinor mrica-equinor force-pushed the remove-steps-isar branch 3 times, most recently from 6833302 to 5d4237a Compare October 15, 2024 10:45
andchiind
andchiind approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Oct 17, 2024
@mrica-equinor
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/11383967806

1 similar comment
@github-actions GitHub Actions
Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/11383967806

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@mrica-equinor mrica-equinor merged commit a0383c3 into equinor:main Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsundvoll tsundvoll tsundvoll left review comments

@oysand oysand oysand left review comments

@andchiind andchiind andchiind approved these changes

Assignees
No one assigned
Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrica-equinor @andchiind @oysand @tsundvoll