Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let user configure custom zoom for tasks #1855

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Let user configure custom zoom for tasks #1855

merged 1 commit into from
Dec 10, 2024

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Dec 6, 2024 •
edited
Loading

This adds an endpoint where we can map an echo tag ID to a zoom value. This is not meant as a permanent solution, but it can be used until an Echo solution is created.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Dec 6, 2024
@andchiind andchiind added backend Backend related functionality improvement Improvement to existing functionality feature New feature or request and removed improvement Improvement to existing functionality labels Dec 6, 2024
@andchiind andchiind self-assigned this Dec 6, 2024
@andchiind andchiind force-pushed the custom-zoom branch 4 times, most recently from 14c87a3 to abf7fc2 Compare December 6, 2024 13:45
Christdej
Christdej requested changes Dec 9, 2024
View reviewed changes
backend/api/Database/Models/EchoTagInspectionMetadata.cs Outdated Show resolved Hide resolved
backend/api/Database/Context/FlotillaDbContext.cs Outdated Show resolved Hide resolved
backend/api/Controllers/EchoController.cs Outdated Show resolved Hide resolved
Christdej
Christdej approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✨ Successfully ran migration command! ✨

@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✨ Successfully ran migration command! ✨

@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/12236097618

@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/12239157699

@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@andchiind andchiind force-pushed the custom-zoom branch 2 times, most recently from b9a64c8 to 8cc9534 Compare December 10, 2024 12:42
@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/12256400715

@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@andchiind andchiind merged commit 4e83bb5 into equinor:main Dec 10, 2024
13 checks passed
@andchiind andchiind deleted the custom-zoom branch December 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality database-change Will require migration feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andchiind @Christdej