Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused video stream object #1869

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Remove unused video stream object #1869

merged 3 commits into from
Dec 13, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 11, 2024 •
edited by sondreo
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol added the improvement Improvement to existing functionality label Dec 11, 2024
@Eddasol Eddasol self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Dec 11, 2024
@Eddasol Eddasol mentioned this pull request Dec 11, 2024
Merged
@Eddasol Eddasol force-pushed the remove-video-stream-object branch from f3cc1ea to e2a2a59 Compare December 11, 2024 14:00
@Eddasol Eddasol marked this pull request as ready for review December 11, 2024 14:02
@Eddasol Eddasol requested a review from sondreo December 11, 2024 14:03
eivindsjovold
eivindsjovold requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@eivindsjovold eivindsjovold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-run snyk checks

@Eddasol Eddasol force-pushed the remove-video-stream-object branch from e2a2a59 to a7e978d Compare December 12, 2024 11:06
sondreo
sondreo approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@sondreo sondreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Has been tested locally.

eivindsjovold
eivindsjovold approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@eivindsjovold eivindsjovold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not tested locally

@Eddasol Eddasol force-pushed the remove-video-stream-object branch from a7e978d to 9fc9320 Compare December 12, 2024 13:57
@Eddasol Eddasol force-pushed the remove-video-stream-object branch from 9fc9320 to d57e26a Compare December 13, 2024 07:30
@Eddasol
Copy link
Contributor Author

Eddasol commented Dec 13, 2024

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit 0af7ea9 into equinor:main Dec 13, 2024
12 of 14 checks passed
@Eddasol Eddasol deleted the remove-video-stream-object branch December 13, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindsjovold eivindsjovold eivindsjovold approved these changes

@sondreo sondreo sondreo approved these changes

Assignees

@Eddasol Eddasol

Labels
database-change Will require migration improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eddasol @sondreo @eivindsjovold