Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batteryState to robot #1871

Closed
wants to merge 2 commits into from
Closed

Add batteryState to robot #1871

wants to merge 2 commits into from

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 12, 2024

PR to make the charging state from the robot available on the robot object. Corresponding frontend change isn't implemented yet to prevent conflict with rewriting/removal of localization.

Related to: equinor/isar#675

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol added feature New feature or request backend Backend related functionality database-change Will require migration labels Dec 12, 2024
@Eddasol Eddasol self-assigned this Dec 12, 2024
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Eddasol Eddasol force-pushed the charging branch 2 times, most recently from a9d2958 to c73b83e Compare December 12, 2024 09:06
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@Eddasol Eddasol marked this pull request as ready for review December 12, 2024 09:16
@Eddasol Eddasol force-pushed the charging branch 2 times, most recently from 0ee5585 to acd1b7e Compare December 12, 2024 10:54
@Eddasol Eddasol closed this Dec 12, 2024
@Eddasol Eddasol deleted the charging branch December 12, 2024 11:03
@Eddasol Eddasol restored the charging branch December 12, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality database-change Will require migration feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant