Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use robotState to see if robot is charging #1873

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Use robotState to see if robot is charging #1873

merged 2 commits into from
Dec 17, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 12, 2024 •
edited
Loading

Related to: equinor/isar#675

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Dec 12, 2024
@Eddasol Eddasol changed the title Charging Use robotState to see if robot is charging Dec 12, 2024
@Eddasol Eddasol marked this pull request as ready for review December 12, 2024 11:09
@Eddasol Eddasol mentioned this pull request Dec 12, 2024
Open
@sondreo sondreo self-requested a review December 13, 2024 07:43
@Eddasol Eddasol force-pushed the charging branch 3 times, most recently from 6387adb to 2ac396f Compare December 13, 2024 13:05
@Eddasol Eddasol requested a review from oysand December 13, 2024 13:06
@Eddasol Eddasol mentioned this pull request Dec 13, 2024
Open
@Eddasol Eddasol added the feature New feature or request label Dec 13, 2024
@Eddasol Eddasol self-assigned this Dec 13, 2024
andchiind
andchiind approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once conflicts have been fixed. Good to also double check the migration ordering after you rebase. Your migration should be the newest one, but sometimes the rebase puts it in the middle.

@Eddasol
Copy link
Contributor Author

Eddasol commented Dec 17, 2024

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit 6b4d156 into equinor:main Dec 17, 2024
14 checks passed
@Eddasol Eddasol deleted the charging branch December 17, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

@sondreo sondreo Awaiting requested review from sondreo

@oysand oysand Awaiting requested review from oysand

Assignees

@Eddasol Eddasol

Labels
database-change Will require migration feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eddasol @andchiind @oysand