Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded nullability in event args #1901

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove unneeded nullability in event args #1901

merged 1 commit into from
Dec 18, 2024

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Dec 18, 2024 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@andchiind andchiind added backend Backend related functionality improvement Improvement to existing functionality labels Dec 18, 2024
@andchiind andchiind self-assigned this Dec 18, 2024
tsundvoll
tsundvoll approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@tsundvoll tsundvoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, RobotFlotillaStatus should always have a value

@andchiind andchiind merged commit 358ee8c into equinor:main Dec 18, 2024
12 checks passed
@andchiind andchiind deleted the excess-nullability branch December 18, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsundvoll tsundvoll tsundvoll approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andchiind @tsundvoll