Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inspection frequency backend crash #990

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix inspection frequency backend crash #990

merged 2 commits into from
Sep 19, 2023

Conversation

andchiind
Copy link
Contributor

Closes #969

@andchiind andchiind added bug Something isn't working backend Backend related functionality labels Aug 30, 2023
@andchiind andchiind self-assigned this Aug 30, 2023
@github-actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Aug 30, 2023
@andchiind
Copy link
Contributor Author

andchiind commented Aug 30, 2023 •
edited
Loading

It doesn't let me change InspectionFrequency directly to bigint from Time format, but since the inspection frequency column is empty anyways in each environment it is not an issue to just delete and re-add the column.

@andchiind
Copy link
Contributor Author

It's worth noting that these database changes have already been applied to dev

@andchiind andchiind force-pushed the 969-inspection-crash branch 2 times, most recently from 1619d5e to b8fd634 Compare September 6, 2023 10:05
Afonso-2403
Afonso-2403 suggested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@Afonso-2403 Afonso-2403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migrations should probably be regenerated so that they don't include making a bunch of properties required when this PR is only about changing the type of the Inspection frequency

@andchiind andchiind force-pushed the 969-inspection-crash branch 2 times, most recently from 0132391 to 2895a6a Compare September 18, 2023 13:29
Afonso-2403
Afonso-2403 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@Afonso-2403 Afonso-2403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andchiind
Copy link
Contributor Author

/UpdateDatabase

@github-actions
Copy link

👀 Running migration command... 👀

@github-actions
Copy link

✨ Successfully ran migration command! ✨

@andchiind andchiind merged commit edd0e74 into equinor:main Sep 19, 2023
@andchiind andchiind deleted the 969-inspection-crash branch September 19, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OleDrange OleDrange OleDrange left review comments

@oysand oysand oysand left review comments

@Afonso-2403 Afonso-2403 Afonso-2403 approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality bug Something isn't working database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect InspectionFrequency crashes backend
4 participants
@andchiind @oysand @OleDrange @Afonso-2403