Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecl to res in docs #259

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Fix ecl to res in docs #259

merged 5 commits into from
Sep 10, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Sep 10, 2024

No description provided.

@larsevj larsevj force-pushed the fix_ecl_to_res_in_docs branch from 600044c to 637c657 Compare September 10, 2024 13:00
@larsevj larsevj force-pushed the fix_ecl_to_res_in_docs branch from 637c657 to a275d94 Compare September 10, 2024 13:03
@larsevj
Copy link
Contributor Author

larsevj commented Sep 10, 2024

Removed pylint and flake8 from test requirements as they are never run during the tests. Can instead look into adding some linting via ruff in seperate pr.

@larsevj larsevj requested a review from berland September 10, 2024 13:14
@larsevj
Copy link
Contributor Author

larsevj commented Sep 10, 2024

Might be preferable to squash some of the commits?

Copy link
Collaborator

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No need to squash.

@larsevj larsevj merged commit d1a1a89 into master Sep 10, 2024
7 checks passed
@larsevj larsevj deleted the fix_ecl_to_res_in_docs branch September 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants