Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing OpenVDS, add warnings #200

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

adnejacobsen
Copy link
Contributor

@adnejacobsen adnejacobsen commented Aug 31, 2023

Handle importing OpenVDS on MacOS and issue warning. Using methods/properties from the Cube class that uses OpenVDS will still raise exceptions.

I had to remove the type hints for Cube properties openvds_handle and openvds_handle_async as this raises exceptions on MacOS and I didn't find a way to do conditional type hinting. Open to suggestions for alternative solutions to this.

@adnejacobsen adnejacobsen requested a review from a team August 31, 2023 10:42
Copy link
Contributor

@equinor-ruaj equinor-ruaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adnejacobsen adnejacobsen merged commit ad21f6d into main Aug 31, 2023
@adnejacobsen adnejacobsen deleted the handle-macos-openvds branch August 31, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants