Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More metadata #268

Merged
merged 2 commits into from
Nov 28, 2023
Merged

More metadata #268

merged 2 commits into from
Nov 28, 2023

Conversation

rwiker
Copy link
Contributor

@rwiker rwiker commented Nov 28, 2023

Change metadata filtering, so that we can specify both "include" and "exclude" sets. This means that the select parameter should be a dictionary containing the keys include and/or exclude, both of which should be lists of attribute names. If one of these is specified as a an empty list, it is treated as missing.

It is also possible to specify select as a list; this will be treated the same as a dictionary with the list as the value of the "include" key.

The default value for case objects is to include everything, while for child objects, we exclude data.spec.columns and fmu.realization.parameters.

@rwiker rwiker requested review from HansKallekleiv and a team November 28, 2023 13:51
@equinor-ruaj
Copy link
Contributor

Does this solve #260 ?

@rwiker
Copy link
Contributor Author

rwiker commented Nov 28, 2023

Yes, I think this solves #260.

Copy link
Contributor

@equinor-ruaj equinor-ruaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rwiker rwiker merged commit d1d3d7a into main Nov 28, 2023
15 checks passed
@rwiker rwiker deleted the more-metadata branch November 28, 2023 14:12
@equinor-ruaj equinor-ruaj linked an issue Nov 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the Explorer exclude instead of include metadata fields?
2 participants