Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access tests using shared-key for auth #291

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

roywilly
Copy link
Contributor

@roywilly roywilly commented Feb 9, 2024

Issue

https://github.com/orgs/equinor/projects/517/views/2?sliceBy%5Bvalue%5D=roywilly&pane=issue&itemId=51867183

Short description

Short description of the approach taken to solve the issue

Pre-review checklist

  • Read through all changes. No redundant print() statements, commented-out code, or other remnants from the development. 👀
  • Make sure tests pass after every commit. ✅
  • New/refactored code is following same conventions as the rest of the code base. 🧬
  • New/refactored code is tested. ⚙
  • Documentation has been updated 🧾

Pre-merge checklist

  • Commit history is consistent and clean. 👌

@roywilly roywilly self-assigned this Feb 9, 2024
@roywilly roywilly requested a review from a team February 9, 2024 11:50
@roywilly roywilly marked this pull request as ready for review February 9, 2024 11:50
@roywilly roywilly force-pushed the add-sharedkey-tests branch from 956b858 to 8c8d57a Compare February 9, 2024 11:57
Copy link
Contributor

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roywilly roywilly merged commit 3b24ac6 into main Feb 9, 2024
21 checks passed
@roywilly roywilly deleted the add-sharedkey-tests branch February 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants