Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer 'expensive' imports until they are needed. #352

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

rwiker
Copy link
Contributor

@rwiker rwiker commented Nov 1, 2024

Also, do a little cleanup based on flake8 findings.

Issue

N/A

Short description

Move some "expensive" imports from top-level of files into the methods where they are needed.

Also (incidentally/accidentally): added a new example notebook showing performance gains when using split tables for aggregation.

Pre-review checklist

  • Read through all changes. No redundant print() statements, commented-out code, or other remnants from the development. 👀
  • Make sure tests pass after every commit. ✅
  • New/refactored code is following same conventions as the rest of the code base. 🧬
  • New/refactored code is tested. ⚙
  • Documentation has been updated 🧾

Pre-merge checklist

  • Commit history is consistent and clean. 👌

@rwiker rwiker requested a review from a team November 1, 2024 12:33
Copy link
Contributor

@ovejorgensen ovejorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwiker rwiker force-pushed the feature/deferred-imports branch from 02d6724 to 9b95331 Compare November 1, 2024 13:01
@rwiker rwiker merged commit 0f7ec1b into main Nov 1, 2024
17 checks passed
@rwiker rwiker deleted the feature/deferred-imports branch November 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants