feat: portal framework #781
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The useAppLoader hook in the core package was updated to handle cases where the basename is missing from the window location pathname. Previously, if the basename was not found, an empty string was used. Now, if the basename is not found, the entire location pathname is used as a fallback. This change ensures that the createAppElement function is called correctly and that the basename is generated accurately for application regex extraction.
The portal configuration types in the core package were updated to include two new properties: portalKey and origin. These properties are required for the type 'app-portal' and will be used to provide additional information about the portal. This change ensures that the portal configuration is accurately represented in the codebase.
The code changes in `ProjectPage.tsx` update the logic to handle cases where the `contextId` is missing or does not match the expected format. Instead of returning the string 'hello', the code now returns `null`. This change ensures that the `ProjectPage` component behaves correctly when the contextId is invalid or missing.
Co-authored-by: Noggling <[email protected]>
🦋 Changeset detectedLatest commit: 7ef957b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- In the `initialize` function of the `module.ts` file, added an optional `args.ref` parameter to the `createConfigAsync` function call. - Modified the return statement to use the `args.ref?.portalConfig` if it exists, otherwise create a new `PortalConfigProvider` with the `config`. - In the `provider.ts` file, updated the `routes$` getter to handle the case when `portal` is null or undefined. - Added a new getter `config` to the `PortalConfigProvider` class to expose the configuration. This commit refactors the `portal-config` module to handle an optional `ref` parameter and improves the handling of the `routes$` getter. It also adds a new getter to expose the configuration. These changes improve the flexibility and reliability of the `portal-config` module.
Remove unused import and unnecessary code in portal-framework package Remove unused import and unnecessary code in portal-framework-config.tsx Add PortalSelector component for portal selection Update FusionFramework component to import ModulesInstance from fusion-framework-module Update PortalRouter component to include PortalSelector component Update portal-framework-config.tsx to remove console.log statement Update main.tsx to use localStorage for portalId if available Add PortalSelector component for portal selection
…r and remove unnecessary code
…l" during loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please select version type the purposed change:
External Relations
Changeset