feat: app list from new app service #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the PortalConfig types in the 'portal-config/types/index.ts' file. It updates the 'Portal' type to 'PortalConfig' and renames the 'client' property to 'IPortalClient'. Additionally, it adds the 'IPortalClient' interface import from the 'portal-client' module.
- The appsToAppCategory function in the portal-config/utils/appsToAppCategory.ts file has been updated to handle the case when the apps array is empty. Previously, it would throw an error if the apps array was not provided. Now, it returns an empty array when no apps are passed as an argument. refactor: Update getColumnCount function to import filter from rxjs - The getColumnCount function in the portal-config/utils/utils.ts file has been updated to import the filter operator from the rxjs library. This operator is used in the function to filter out null and undefined values. feat: Update createPortalFramework function to use current.portalConfig$ - The createPortalFramework function in the portal-client/src/lib/portal-framework-config.tsx file has been updated to use the current.portalConfig$ observable instead of the portalConfig.portal$ observable. This change ensures that the document title is updated with the correct portal name when the portal configuration changes. feat: Add fetchApps action to fetch all apps - The fetchApps action has been added to the portal-config/state/actions.ts file. This action is used to fetch all apps from the server. It takes an optional update parameter to indicate whether the fetched apps should replace the existing apps in the state. chore: Update createState function to include handleFetchApps flow - The createState function in the portal-config/state/create-state.ts file has been updated to include the handleFetchApps flow. This flow is responsible for fetching all apps and updating the state accordingly. refactor: Update createReducer function to use PortalConfig type - The createReducer function in the portal-config/state/create-reducer.ts file has been updated to use the PortalConfig type instead of the Portal type. This change ensures that the reducer correctly handles the portal configuration. feat: Add usePortal hook to retrieve portal configuration - The usePortal hook has been added to the portal-config/hooks/use-portal-config.ts file. This hook is used to retrieve the portal configuration from the framework's modules. feat: Add usePortalAppsConfig hook to retrieve portal apps configuration - The usePortalAppsConfig hook has been added to the portal-config/hooks/use-portal-config.ts file. This hook is used to retrieve the portal apps configuration from the framework's modules. feat: Add usePortalRouter hook to retrieve portal router configuration - The usePortalRouter hook has been added to the portal-config/hooks/use-portal-config.ts file. This hook is used to retrieve the portal router configuration from the framework's modules.
🦋 Changeset detectedLatest commit: fe5e770 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…eval The usePortalApps hook in the portal-apps module has been updated to handle the retrieval of apps based on the current context. Previously, it only retrieved all apps, but now it checks if the portal is a context portal and subscribes to changes in the current context. If it is a context portal, it retrieves the app keys specific to that context. This change improves the functionality and flexibility of the hook.
…xtParameters for better clarity
kjetilhau
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please select version type the purposed change:
External Relations
Changeset