Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove unused portal apps API endpoints, cleanup compiler warnings #853

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

kjetilhau
Copy link
Member

@kjetilhau kjetilhau commented Nov 5, 2024

Description

Updates the API endpoints that gives Portal Apps as list of objects:

  • {portalId:guid}/apps
  • {portalId:guid}/contexts/{contextId:guid}/apps

Now instead, these endpoint returns a list of appKeys (strings).

The old ones:

  • {portalId:guid}/appkeys
  • {portalId:guid}/contexts/{contextId:guid}/appkeys

are now identical, and are deprecated and will be removed when front-end has adopted the updated endpoints.

In addition some refactoring has been done. As a result, compiler warnings has been greatly reduced

  • PR title and description are to the point and understandable
  • I have performed a self-review of my own code'

Please select version type the purposed change:

  • major
  • minor
  • patch
  • none

External Relations

  • database migration

Changeset

BREAKING CHANGE:

Updates the API endpoints that gives Portal Apps as list of objects:

{portalId:guid}/apps
{portalId:guid}/contexts/{contextId:guid}/apps
Now instead, these endpoint returns a list of appKeys (strings).

The old ones:

{portalId:guid}/appkeys
{portalId:guid}/contexts/{contextId:guid}/appkeys
are now identical, and are deprecated and will be removed when front-end has adopted the updated endpoints.

In addition some refactoring has been done. As a result, compiler warnings has been greatly reduced

@kjetilhau kjetilhau requested a review from Noggling November 5, 2024 13:35
@kjetilhau kjetilhau requested a review from a team as a code owner November 5, 2024 13:35
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 853a476

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fusion-project-portal Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjetilhau kjetilhau changed the title minor: remove unused portal apps API endpoints, cleanup compiler warnings breaking: remove unused portal apps API endpoints, cleanup compiler warnings Nov 5, 2024
@kjetilhau kjetilhau self-assigned this Nov 5, 2024
@kjetilhau kjetilhau merged commit e763969 into main Nov 8, 2024
3 checks passed
@kjetilhau kjetilhau deleted the chore/fix-warnings branch November 8, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Portal API: Optimize models and data fetching to reduce only necessary fields
2 participants