Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepper): stepper component #904

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

AndrejNikolicEq
Copy link
Contributor

Component Development

Stepper

New stepper component, created from stepper in react components

Type

  • Feature
  • Fix
  • Hotfix (should release ASAP)
  • Maintenance (deps only)

Reference to assignment

As a app developer, I want to have stepper as a react component so that app teams can reuse it

Create a stepper componen

close #816

Description of assignment

Create a stepper in react components

Checklist

Create User Story(DevOps) or Issue(Github)

  • Describe functional requirements
  • Design plan/suggestion (e.g. images, link to eds design or relevant figma links, mention of eds tokens to use)
  • Communication with UX (evaluate if needed)

Development

  • Describe the component
  • Code funtional requirements
  • Create stories
  • Create snapshots (evaluate if needed)
  • Remove unused imports and commented code
  • Lint code with EsLint (and follow best practises for code quality

Create Pull Request

  • Assign relevant reviewers in Github and Cromatic
  • Inform colleagues of pending reviews. We use Teams for this purpose, under fusion-frontend team please tag involved reviewers in the Code review channel

Review of Pull Request

  • Follow up on comments from code review and implement necessary changes (evaluate if needed)
  • Review approved in github (and chromatic)

Publish Code

  • Increment version number
  • Merge PR
  • Consider letting fusion developers know this this shiny new thing exists

@AndrejNikolicEq AndrejNikolicEq added enhancement New feature or request prioritized ASAP labels Jul 12, 2023
@AndrejNikolicEq AndrejNikolicEq requested a review from a team July 12, 2023 10:32
@AndrejNikolicEq AndrejNikolicEq merged commit 10c7b85 into main Jul 12, 2023
@AndrejNikolicEq AndrejNikolicEq deleted the feat/react-components/stepper branch July 12, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prioritized ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a stepper component
2 participants