-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin dependencies #103
Pin dependencies #103
Conversation
8d868ee
to
7f3310c
Compare
7f3310c
to
6264ce2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks good to me. I am wondering some about the purpose of snyk_check.yml
(see the specific comment for details), and also how and whenrequiremnts.txt
is to be updated (what will be the policy for updating it, should we do it as part of a workflow or perhaps pre-commit-hook?)
Summary from discussion:
We can take in this PR, and I will add the pre-commit hook later, since this setup provides some value already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
No description provided.