Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set id in Inspection at instantiation of Image etc #181

Merged

Conversation

tsundvoll
Copy link
Contributor

No description provided.

@tsundvoll tsundvoll closed this Dec 11, 2024
@tsundvoll tsundvoll force-pushed the rename-inspection-to-inspectionresult branch from 3f1b350 to fb2ef10 Compare December 11, 2024 14:22
@tsundvoll tsundvoll reopened this Dec 11, 2024
@tsundvoll tsundvoll added breaking-change A breaking change which introduces changes to the public APIs improvement Improvement to existing functionality labels Dec 11, 2024
to be equal the incoming task.inspection_id
to get type checking with mypy
@tsundvoll tsundvoll force-pushed the rename-inspection-to-inspectionresult branch from fb2ef10 to 71ed1a2 Compare December 11, 2024 14:54
@tsundvoll tsundvoll changed the title Rename inspection to inspectionresult Set id in Inspection at instantiation of Image etc Dec 12, 2024
Copy link
Contributor

@Eddasol Eddasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tsundvoll tsundvoll merged commit 76b3283 into equinor:main Dec 13, 2024
4 checks passed
@tsundvoll tsundvoll deleted the rename-inspection-to-inspectionresult branch December 13, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change which introduces changes to the public APIs improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants