-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline state refactor robot status #549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
oysand
force-pushed
the
offline-state-refactor-robot-status
branch
4 times, most recently
from
May 3, 2024 12:18
51148e4
to
c52173d
Compare
Should be combined with update in flotilla to utilize the new status topic from isar rather than robot_status: |
oysand
added
the
breaking-change
A breaking change which introduces changes to the public APIs
label
May 16, 2024
oysand
commented
May 16, 2024
oysand
force-pushed
the
offline-state-refactor-robot-status
branch
from
May 16, 2024 08:38
8024f3f
to
0a4b573
Compare
Co-authored-by: Anders Chirico Indrebø <[email protected]>
oysand
force-pushed
the
offline-state-refactor-robot-status
branch
from
May 16, 2024 08:49
0a4b573
to
20d8fb8
Compare
andchiind
reviewed
May 16, 2024
andchiind
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.