Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline state refactor robot status #549

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

oysand
Copy link
Contributor

@oysand oysand commented May 2, 2024

No description provided.

@oysand oysand mentioned this pull request May 2, 2024
@oysand oysand force-pushed the offline-state-refactor-robot-status branch 4 times, most recently from 51148e4 to c52173d Compare May 3, 2024 12:18
@oysand oysand marked this pull request as ready for review May 3, 2024 12:19
@oysand
Copy link
Contributor Author

oysand commented May 3, 2024

Should be combined with update in flotilla to utilize the new status topic from isar rather than robot_status:

equinor/flotilla#1584

@oysand oysand added the breaking-change A breaking change which introduces changes to the public APIs label May 16, 2024
@oysand oysand force-pushed the offline-state-refactor-robot-status branch from 8024f3f to 0a4b573 Compare May 16, 2024 08:38
@oysand oysand force-pushed the offline-state-refactor-robot-status branch from 0a4b573 to 20d8fb8 Compare May 16, 2024 08:49
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/isar/state_machine/states/idle.py Show resolved Hide resolved
src/isar/state_machine/states/idle.py Show resolved Hide resolved
@oysand oysand merged commit 95210fc into main May 24, 2024
3 checks passed
@oysand oysand deleted the offline-state-refactor-robot-status branch May 24, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change which introduces changes to the public APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants