Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused video stream object #672

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove unused video stream object #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions src/isar/config/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from isar.config import predefined_missions
from robot_interface.models.robots.robot_model import RobotModel
from robot_interface.telemetry.payloads import DocumentInfo, VideoStream
from robot_interface.telemetry.payloads import DocumentInfo


class Settings(BaseSettings):
Expand Down Expand Up @@ -194,22 +194,6 @@ def __init__(self) -> None:
# Info about robot documentation
DOCUMENTATION: List[DocumentInfo] = Field(default=[])

# Endpoints to reach video streams for the robot
VIDEO_STREAMS: List[VideoStream] = Field(
Eddasol marked this conversation as resolved.
Show resolved Hide resolved
default=[
VideoStream(
name="Front camera",
url="http://localhost:5000/videostream/front",
type="turtlebot",
),
VideoStream(
name="Rear camera",
url="http://localhost:5000/videostream/rear",
type="turtlebot",
),
]
)

# Data scheme the robot should adhere to
# Options [DS0001]
DATA_SCHEME: str = Field(default="DS0001")
Expand Down
1 change: 0 additions & 1 deletion src/isar/services/service_connections/mqtt/robot_info_publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ def run(self) -> None:
robot_serial_number=settings.SERIAL_NUMBER,
robot_asset=settings.PLANT_SHORT_NAME,
documentation=settings.DOCUMENTATION,
video_streams=settings.VIDEO_STREAMS,
host=settings.API_HOST_VIEWED_EXTERNALLY,
port=settings.API_PORT,
capabilities=robot_settings.CAPABILITIES,
Expand Down
8 changes: 0 additions & 8 deletions src/robot_interface/telemetry/payloads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ class DocumentInfo:
url: str


@dataclass
class VideoStream:
name: str
url: str
type: str


@dataclass
class RobotStatusPayload:
isar_id: str
Expand All @@ -76,7 +69,6 @@ class RobotInfoPayload:
robot_serial_number: str
robot_asset: str
documentation: List[DocumentInfo]
video_streams: List[VideoStream]
host: str
port: int
capabilities: List[str]
Expand Down
Loading