Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff workflow to prevent unused imports #684

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 16, 2024

Removing InitializeParams from init file means that all isar-"robot" repos using the line below:
from robot_interface.models.initialize import InitializeParams
will have to change it to:
from robot_interface.models.initialize.initialize_params import InitializeParams

@Eddasol Eddasol added breaking-change A breaking change which introduces changes to the public APIs refactor Refactoring of old functionality labels Dec 16, 2024
@Eddasol Eddasol self-assigned this Dec 16, 2024
@Eddasol Eddasol marked this pull request as ready for review December 16, 2024 14:27
@Eddasol
Copy link
Contributor Author

Eddasol commented Dec 16, 2024

Copy link
Contributor

@tsundvoll tsundvoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Good idea to implement ruff to the linting 👍

@Eddasol Eddasol merged commit 1968e0c into equinor:main Dec 17, 2024
7 checks passed
@Eddasol Eddasol deleted the ruff branch December 17, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change which introduces changes to the public APIs refactor Refactoring of old functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants