Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return home #725

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add return home #725

wants to merge 2 commits into from

Conversation

oysand
Copy link
Contributor

@oysand oysand commented Feb 19, 2025

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@oysand oysand force-pushed the add-return-home branch 3 times, most recently from b9421a3 to 0733412 Compare February 19, 2025 12:54
@oysand
Copy link
Contributor Author

oysand commented Feb 19, 2025

To be combined with: equinor/isar-robot#206

@oysand oysand linked an issue Feb 19, 2025 that may be closed by this pull request
Add return to home functionality #701
Open
@oysand oysand force-pushed the add-return-home branch 2 times, most recently from a9519c1 to f3ff12c Compare February 21, 2025 14:04
@oysand
Copy link
Contributor Author

oysand commented Feb 21, 2025

To be combined with: equinor/flotilla#2041

andchiind
andchiind reviewed Feb 26, 2025
View reviewed changes
src/isar/state_machine/states/await_next_mission.py
from isar.state_machine.state_machine import StateMachine


class AwaitNextMission(State):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need both this state and Idle?

src/isar/state_machine/states/docked.py
from isar.state_machine.state_machine import StateMachine


class Docked(State):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have a docked state that implies that the robot is not docked in Idle. Should we rename Idle to reflect this?

@oysand oysand force-pushed the add-return-home branch 4 times, most recently from ed385f0 to 12033bd Compare March 6, 2025 10:55
@oysand oysand force-pushed the add-return-home branch from 12033bd to 4bd638e Compare March 6, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add return to home functionality
2 participants
@oysand @andchiind