Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Komodo portable #124

Open
jondequinor opened this issue Jun 29, 2020 · 0 comments
Open

Make Komodo portable #124

jondequinor opened this issue Jun 29, 2020 · 0 comments
Labels
christmas-review Issues and PRs for Christmas review enhancement major-refactor

Comments

@jondequinor
Copy link
Contributor

Calls to bash, rsync, pip via komodo.shell are hard to debug. STDOUT is swallowed, and it is non-trivial to spit this out again. The assumption here is that all useful info goes over STDERR, which is not always true.

These calls also represents a very turbulent boundary between textual interfaces and Python. You send in strings and get strings back. It in most cases this prevents Komodo from doing any thing intelligent to—or reasoning about why—something failing. Exceptions > error codes.

And it has value that it is easy to run komodo on non-Redhat machines. In the cloud you might use Alpine which ships busybox (subset of normal linux utils). If you run on Debian (and derivatives), the default renamer will crash.

Testing should be easy
At what level should you mock? There's only one available, and that's komodo. And most often komodo is a thin layer on top of a bunch of binaries. Does komodo need testing? Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review Issues and PRs for Christmas review enhancement major-refactor
Projects
None yet
Development

No branches or pull requests

2 participants