Modify branch name when symlink suggester updates azure configs #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, sorry, I didn't realize this was just a draft. Can review again when finished. |
Checks if the json symlink file contains azure and pull request branch name includes azure suffix.
Now it's ready for review :) |
|
Still seems good. Maybe you could also make an issue that this is another hardcoded dependency on Equinor's setup? If and when we want to generalize this sort of thing. |
The related issue: #333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/equinor/komodo-releases/issues/3183
Checks if updater acts on
symlink_configuration/symlink_config_azure.jsonand appends/azureto release name yielding for instance:release_name/unstable/azurebranch name.todo: tests