Add ask for tags script #340
Conversation
valentin-krasontovitsch
force-pushed
the
ask-for-tags-message-script
branch
2 times, most recently
from
f1f4b6a to
42569f5
Compare
The idea of this script is to automate part of the release management process - it allows checking for internal dependencies that have changes on their default branch since their latest release, and composes a message that can be used to poke maintainers and invite them to create a new tag.
valentin-krasontovitsch
force-pushed
the
ask-for-tags-message-script
branch
from
42569f5 to
dd688db
Compare
|
As discussed Valentin - this PR needs to wait until the release process and proposal of changing it has been approved in Scout |
| bleeding_release_file = "releases/matrices/bleeding.yml" | ||
| duplicate_pkgs = ["everest-models"] # this is included in the everest repo |
There was a problem hiding this comment.
In principle, komodo is a general purpose FOSS tool. I wonder if it's possible to write the functions in this module in such a way that they do not assume it's only being run by Equinor? I will mark some other lines that can perhaps be refactored.
There was a problem hiding this comment.
(Just to add: another possibility is that this project is not meant for general consumption at all, which is totally fine -- but then we should either close it or make it clear that it's an Equinor tool.)
| DEFAULT_FORK = "equinor" | ||
| ALTERNATE_FORK = "tno-everest" |
| def get_scout_maintainers(gh_client: Github) -> Mapping[str, str]: | ||
| scout_repo = gh_client.get_repo("equinor/scout") | ||
| projects_file = scout_repo.get_contents("projects.md") | ||
| projects_file_contents = base64.b64decode(projects_file.content).decode() |
There was a problem hiding this comment.
More Equinor specific stuff. Maybe we can generalize this, I'm not sure. We've been wondering if other parts of the code could benefit from a local config file -- possibly this is locations.yaml or maybe some new thing. This seems like the kind of thing that could go in there.
| raise ValueError( | ||
| "Please provide a github access token through the env var `GITHUB_TOKEN`\n" | ||
| "Note that the token should be a personal access token " | ||
| "(not fine-grained),\n configured for SSO with equinor" |
|
thanks for the comments @kwinkunks - i was thinking along those same lines, and of course you are right, this violates 12-factor in so many ways : ) i also now discovered a bug, and will try to address the points you raise while working on a fix! |
I would also suggest to wait with the changes and pause work on this PR until we have a decision on how we want to proceed with the release process. |
|
i'm unassigning myself as I'm leaving scout - @eivindjahren, since we talked a lot about this, maybe you could try to find somebody to take this further (e.g. current up and coming release manager @yngve-sk), or close as not desired |
|
@eivindjahren Do you think we should close this as abandoned? |
|
@jonathan-eq I think this is still up for discussion, |
The idea of this script is to automate part of the release management process - it allows checking for internal dependencies that have changes on their default branch since their latest release, and composes a message that can be used to poke maintainers and invite them to create a new tag.