Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julevask 2023 #421

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Julevask 2023 #421

merged 5 commits into from
Dec 29, 2023

Conversation

jonathan-eq
Copy link
Collaborator

@jonathan-eq jonathan-eq commented Dec 21, 2023

@jonathan-eq jonathan-eq added the maintenance Not a bug now but could be one day, repaying technical debt label Dec 21, 2023
Copy link
Member

@kwinkunks kwinkunks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions:

  • Update the versioning in GitHub Actions, eg actions/checkout@v3 should be v4 and python-setup should be v5. There may be others.
  • Remove Packages and maybe Releases as well from the main page (in About cog thingy)
  • Remove Hacktoberfest tag and maybe add some relevant ones like 'Enterprise', 'Distribution' sort of thing
  • We are publishing the docs to GitHub Page in one of the actions, but they are not deployed. I think this just needs to be enabled in Settings > Pages. They should appear here https://equinor.github.io/komodo (there's a link in the README but it 404s)

@jonathan-eq
Copy link
Collaborator Author

Great feedback @kwinkunks! I will update it right away.
The docs are published in a github actions step, but it does not seem to work. See issue #423

README.md Show resolved Hide resolved
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks very good now @jonathan-eq !

@jonathan-eq jonathan-eq merged commit 7ff53ee into equinor:main Dec 29, 2023
6 checks passed
@jonathan-eq jonathan-eq deleted the julevask-2023 branch December 29, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants