Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds suggest deprecated symlink capability #520

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Adds suggest deprecated symlink capability #520

merged 1 commit into from
Dec 12, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Dec 5, 2024 •
edited
Loading

Resolves https://github.com/equinor/komodo-releases/issues/6405

When using the propose symlink pr workflow, this yielded the following:

Symlink change deprecated to 2024.11.12

diff --git a/symlink_configuration/symlink_config.json b/symlink_configuration/symlink_config.json
index 7bfc3b20..03c9fe5d 100644
--- a/symlink_configuration/symlink_config.json
+++ b/symlink_configuration/symlink_config.json
@@ -54,2 +54,2 @@
-        "2024.11-py311": "2024.11.11-py311",
-        "2024.11-py38": "2024.11.11-py38",
+        "2024.11-py311": "2024.11.12-py311",
+        "2024.11-py38": "2024.11.12-py38",
@@ -64 +64 @@
-        "deprecated-py311": "2024.10-py311",
+        "deprecated-py311": "2024.11-py311",
@@ -66 +66 @@
-        "deprecated-py38": "2024.10-py38",
+        "deprecated-py38": "2024.11-py38",
@@ -137 +137,3 @@
-        "2024.09-py311"
+        "2024.09-py311",
+        "2024.10-py311",
+        "2024.10-py38"
diff --git a/symlink_configuration/symlink_config_azure.json b/symlink_configuration/symlink_config_azure.json
index 96f816f4..cbf6c0ca 100644
--- a/symlink_configuration/symlink_config_azure.json
+++ b/symlink_configuration/symlink_config_azure.json
@@ -26,2 +26,2 @@
-        "2024.11-py311": "2024.11.11-py311",
-        "2024.11-py38": "2024.11.11-py38",
+        "2024.11-py311": "2024.11.12-py311",
+        "2024.11-py38": "2024.11.12-py38",
@@ -34,2 +34,2 @@
-        "deprecated-py311": "2024.10-py311",
-        "deprecated-py38": "2024.10-py38",
+        "deprecated-py311": "2024.11-py311",
+        "deprecated-py38": "2024.11-py38",
@@ -76 +76,3 @@
-        "2024.09-py311"
+        "2024.09-py311",
+        "2024.10-py311",
+        "2024.10-py38"

@andreas-el andreas-el force-pushed the add_deprecated_symlink_capability branch from 447bbde to f1b8ca5 Compare December 5, 2024 13:55
@andreas-el andreas-el assigned andreas-el and unassigned andreas-el Dec 5, 2024
@andreas-el andreas-el force-pushed the add_deprecated_symlink_capability branch 3 times, most recently from 838412e to 386e6f9 Compare December 11, 2024 15:16
eivindjahren
eivindjahren approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@andreas-el andreas-el force-pushed the add_deprecated_symlink_capability branch from 386e6f9 to 8320d88 Compare December 12, 2024 10:58
@andreas-el andreas-el merged commit 4e2bace into main Dec 12, 2024
5 checks passed
@andreas-el andreas-el deleted the add_deprecated_symlink_capability branch December 12, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindjahren eivindjahren eivindjahren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreas-el @eivindjahren