improve flash

equinor · Nov 26, 2023 · 7a68815 · 7a68815
1 parent dad7d81
commit 7a68815
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 19 deletions.
diff --git a/src/main/java/neqsim/thermodynamicOperations/flashOps/TPmultiflash.java b/src/main/java/neqsim/thermodynamicOperations/flashOps/TPmultiflash.java
@@ -28,6 +28,7 @@ public class TPmultiflash extends TPflash {
   static Logger logger = LogManager.getLogger(TPmultiflash.class);
 
   // SystemInterface clonedSystem;
+  boolean startFromBottom = true;
   boolean multiPhaseTest = false;
   double[][] dQdbeta;
   double[][] Qmatrix;
@@ -340,7 +341,15 @@ public void stabilityAnalysis() {
       }
     }
 
-    for (int j = system.getPhase(0).getNumberOfComponents() - 1; j >= 0; j--) {
+    int start = system.getPhase(0).getNumberOfComponents() - 1;
+    int end = 0;
+    int val = -1;
+    if (!startFromBottom) {
+      start = 0;
+      val = 1;
+      end = system.getPhase(0).getNumberOfComponents() - 1;
+    }
+    for (int j = start; j != end; j = j + val) {
       if (minimumGibbsEnergySystem.getPhase(0).getComponent(j).getx() < 1e-100
           || (minimumGibbsEnergySystem.getPhase(0).getComponent(j).getIonicCharge() != 0)
           || (minimumGibbsEnergySystem.getPhase(0).getComponent(j).isHydrocarbon()
@@ -372,6 +381,7 @@ public void stabilityAnalysis() {
       double errOld = 1.0e100;
       boolean useaccsubst = true;
       do {
+        clonedSystem.get(0).init(1);
         errOld = err;
         iter++;
         err = 0;
@@ -1028,6 +1038,8 @@ public void run() {
        */
       if (hasRemovedPhase && !secondTime) {
         secondTime = true;
+        startFromBottom = false;
+        stabilityAnalysis();
         run();
       }
       /*

diff --git a/src/test/java/neqsim/thermodynamicOperations/flashOps/TPFlashTest.java b/src/test/java/neqsim/thermodynamicOperations/flashOps/TPFlashTest.java
@@ -1,7 +1,6 @@
 package neqsim.thermodynamicOperations.flashOps;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import neqsim.thermodynamicOperations.ThermodynamicOperations;
@@ -143,7 +142,7 @@ void testRun6() {
 
   @Test
   void testTPflash1() {
-    testSystem = new neqsim.thermo.system.SystemSrkEos(273.15 + 177.0, 316.0);
+    testSystem = new neqsim.thermo.system.SystemSrkEos(273.15 + 290, 400.0);
     testSystem.addComponent("water", 65.93229747922976);
     testSystem.addComponent("NaCl", 0.784426208131475);
     testSystem.addComponent("nitrogen", 0.578509157534656);
@@ -166,23 +165,11 @@ void testTPflash1() {
     testSystem.setMixingRule("classic");
     testSystem.setMultiPhaseCheck(true);
     testOps = new ThermodynamicOperations(testSystem);
+    testOps.TPflash();
+    testSystem.prettyPrint();
+
+  }
 
-    for (int i = 0; i < 50; i++) {
-      testSystem.setTemperature(i, "C");
-      for (int j = 1; j < 50; j++) {
-        testSystem.setPressure(j, "bara");
-        try {
-          testOps.TPflash();
-          testSystem.initProperties();
-        } catch (Exception e) {
-          System.out.println("temperature " + testSystem.getTemperature("C") + " pressure "
-              + testSystem.getPressure("bara"));
-          e.printStackTrace();
-          assertTrue(false);
-        }
-      }
-    }
 
 
-  }
 }