Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve flash #1205

Merged
merged 6 commits into from
Dec 9, 2024
Merged

improve flash #1205

merged 6 commits into from
Dec 9, 2024

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Dec 9, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes missing coverage. Please review.

Project coverage is 40.80%. Comparing base (0a880ae) to head (7cb35f4).

Files with missing lines Patch % Lines
...neqsim/thermodynamicoperations/flashops/Flash.java 25.00% 5 Missing and 1 partial ⚠️
...rmodynamicoperations/flashops/TVfractionFlash.java 58.33% 4 Missing and 1 partial ⚠️
...ermodynamicoperations/ThermodynamicOperations.java 50.00% 2 Missing ⚠️
...thermodynamicoperations/flashops/TPmultiflash.java 0.00% 2 Missing ⚠️
...qsim/standards/oilquality/Standard_ASTM_D6377.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1205      +/-   ##
============================================
- Coverage     40.84%   40.80%   -0.05%     
+ Complexity     5909     5901       -8     
============================================
  Files           717      717              
  Lines         67845    67867      +22     
  Branches       8104     8107       +3     
============================================
- Hits          27712    27691      -21     
- Misses        38468    38512      +44     
+ Partials       1665     1664       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit d21106b into master Dec 9, 2024
11 checks passed
@EvenSol EvenSol deleted the test-new-process-model branch December 9, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants