Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update valve calc #1210

Merged
merged 1 commit into from
Dec 11, 2024
Merged

update valve calc #1210

merged 1 commit into from
Dec 11, 2024

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Dec 11, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.80%. Comparing base (d1007e2) to head (2b5f92d).

Files with missing lines Patch % Lines
...eqsim/process/equipment/valve/ThrottlingValve.java 73.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1210   +/-   ##
=========================================
  Coverage     40.80%   40.80%           
- Complexity     5907     5913    +6     
=========================================
  Files           717      717           
  Lines         67888    67901   +13     
  Branches       8111     8113    +2     
=========================================
+ Hits          27699    27710   +11     
- Misses        38525    38526    +1     
- Partials       1664     1665    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol merged commit 17f3baf into master Dec 11, 2024
12 checks passed
@EvenSol EvenSol deleted the valveDP-set branch December 11, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants