Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

170 improve method to set flow rate for a fluid #696

Closed
wants to merge 174 commits into from

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented May 22, 2023

No description provided.

EvenSol and others added 30 commits May 22, 2023 12:27
Set Java_home variable in codespaces config.
* added checkstyle config xml file to specify which warnings to produce
* refact: use useing pattern for disposable/close objects

* close connectors
* added new TPflash test

* update

* updated TP flash test

* Update settings.json
add test
add delta for test that failed in mac m1 environment
style: formatting
* refact: autoformatting and fix of checkstyle violations
* added getPressure() setPressure()

* update

* added setPressure

* update
* fix bug compressor

* remove unused variable
* chore: fixed some warnings
* Update pom.xml

* Update pom.xml
* Update pom.xml

* Update pom.xml

* Update pom.xml

* Update pom.xml
* add Java8 pom

* update
asmfstatoil and others added 22 commits May 22, 2023 12:27
* refact: cleaned up doc and name of checkForSolids
* chore: move main methods to test methods.

---------

Co-authored-by: Even Solbraa <[email protected]>
* bugfix: StateOfMatter missing Hydrate and returing liquid not solid
* bugfix: get correct physicalproperties
* refact: move long package paths to import section...
* bugfix: Mix Mole Percent is always 100%
* refact: simplify if nesting
* refact: addComponent
* refact: deprecate redundant getNumberOfMoles
* refactor: propertyFlash method
* test: improve test for propertyFlash
* add regression test input
* test: disable failing test
* feat: added getUnit, copy methods to modules

* style

---------

Co-authored-by: Åsmund Våge Fannemel <[email protected]>
* refact: create StreamMeasurementDeviceBaseClass
* refact: measurementdevice classes
* test: convert main to test
* test: add tests
* refact: verify input units for setHead
* test: addTests
* move_addHydratePhase2
* move changecomponentname
* move component name setters/getters
* move clone
* move addtocomponentnames
* hasPhaseType and moved hasSolidPhase
* reorder getphase
* marked a bug
* added test for addFLuids

* updated test

* updated test with new pseudo component

* solution for bug

* refact: simplified if-else nesting

---------

Co-authored-by: Åsmund Våge Fannemel <[email protected]>
* added test for addFLuids

* updated test

* updated test with new pseudo component

* solution for bug

* add test TPflas high

* added gitlense extension

* update

* update

* update test
* waterDegasserBugs

* style and assert@

* update from master (#690)

* 684 addfluid is not adding pc if not existing (#685)

* added test for addFLuids

* updated test

* updated test with new pseudo component

* solution for bug

* refact: simplified if-else nesting

---------

Co-authored-by: Åsmund Våge Fannemel <[email protected]>

* dont do log of zeros (#688)

---------

Co-authored-by: Åsmund Våge Fannemel <[email protected]>

* modeidief test

* log off

* rebase on master (#693)

* 684 addfluid is not adding pc if not existing (#685)

* added test for addFLuids

* updated test

* updated test with new pseudo component

* solution for bug

* refact: simplified if-else nesting

---------

Co-authored-by: Åsmund Våge Fannemel <[email protected]>

* dont do log of zeros (#688)

* AddfluidHighTemp (#689)

* added test for addFLuids

* updated test

* updated test with new pseudo component

* solution for bug

* add test TPflas high

* added gitlense extension

* update

* update

* update test

---------

Co-authored-by: Åsmund Våge Fannemel <[email protected]>

* added pretty print for table

* added prettyPrint + various fixes to PhaseType use

* copy phasetype object in clone method

* removed phasetpye setter not needed?

* disable test that throws run tim exception

* fixed doc

* fixed doc

* added BWRS parameter table

* exception handling BWRS

* updated glycol rigtest

* disable pH test

* fixed bug

* enabled test ph test

* added serialization test back again

---------

Co-authored-by: Sviatoslav Eroshkin <[email protected]>
Co-authored-by: Åsmund Våge Fannemel <[email protected]>
@EvenSol EvenSol linked an issue May 22, 2023 that may be closed by this pull request
@EvenSol
Copy link
Collaborator Author

EvenSol commented Jul 5, 2023

public void setTotalFlowRate(double flowRate, String flowunit) {
setTotalFlowRate(1.0) - can be solution where flow rate is low and init(1) gives an exception in volume calc
init(0);
init(1);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve method to set flow rate for a fluid
5 participants