-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
170 improve method to set flow rate for a fluid #696
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set Java_home variable in codespaces config.
* added checkstyle config xml file to specify which warnings to produce
* refact: use useing pattern for disposable/close objects * close connectors
* added new TPflash test * update * updated TP flash test * Update settings.json
add test add delta for test that failed in mac m1 environment
style: formatting
* refact: autoformatting and fix of checkstyle violations
* added getPressure() setPressure() * update * added setPressure * update
#545) Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.18.0 to 2.19.0. See this package in Maven Repository: https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core/ See this project in Snyk: https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>
…#544) Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.18.0 to 2.19.0. See this package in Maven Repository: https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api/ See this project in Snyk: https://app.snyk.io/org/neqsim/project/86e71bb0-950f-445f-94e7-32e73d92cca3?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>
* fix bug compressor * remove unused variable
* chore: fixed some warnings
* Update pom.xml * Update pom.xml
* Update pom.xml * Update pom.xml * Update pom.xml * Update pom.xml
This reverts commit 3cd9ee7.
* add Java8 pom * update
* refact: cleaned up doc and name of checkForSolids
* chore: move main methods to test methods. --------- Co-authored-by: Even Solbraa <[email protected]>
* refact: cleanup various setBeta stuff
* bugfix: StateOfMatter missing Hydrate and returing liquid not solid * bugfix: get correct physicalproperties * refact: move long package paths to import section...
* bugfix: Mix Mole Percent is always 100% * refact: simplify if nesting * refact: addComponent * refact: deprecate redundant getNumberOfMoles
* refactor: propertyFlash method * test: improve test for propertyFlash
* add regression test input * test: disable failing test
* feat: added getUnit, copy methods to modules * style --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]>
* refact: create StreamMeasurementDeviceBaseClass * refact: measurementdevice classes * test: convert main to test * test: add tests
* refact: verify input units for setHead * test: addTests
* move_addHydratePhase2 * move changecomponentname * move component name setters/getters * move clone * move addtocomponentnames * hasPhaseType and moved hasSolidPhase * reorder getphase * marked a bug
* added test for addFLuids * updated test * updated test with new pseudo component * solution for bug * refact: simplified if-else nesting --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]>
* added test for addFLuids * updated test * updated test with new pseudo component * solution for bug * add test TPflas high * added gitlense extension * update * update * update test
* waterDegasserBugs * style and assert@ * update from master (#690) * 684 addfluid is not adding pc if not existing (#685) * added test for addFLuids * updated test * updated test with new pseudo component * solution for bug * refact: simplified if-else nesting --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]> * dont do log of zeros (#688) --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]> * modeidief test * log off * rebase on master (#693) * 684 addfluid is not adding pc if not existing (#685) * added test for addFLuids * updated test * updated test with new pseudo component * solution for bug * refact: simplified if-else nesting --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]> * dont do log of zeros (#688) * AddfluidHighTemp (#689) * added test for addFLuids * updated test * updated test with new pseudo component * solution for bug * add test TPflas high * added gitlense extension * update * update * update test --------- Co-authored-by: Åsmund Våge Fannemel <[email protected]> * added pretty print for table * added prettyPrint + various fixes to PhaseType use * copy phasetype object in clone method * removed phasetpye setter not needed? * disable test that throws run tim exception * fixed doc * fixed doc * added BWRS parameter table * exception handling BWRS * updated glycol rigtest * disable pH test * fixed bug * enabled test ph test * added serialization test back again --------- Co-authored-by: Sviatoslav Eroshkin <[email protected]> Co-authored-by: Åsmund Våge Fannemel <[email protected]>
public void setTotalFlowRate(double flowRate, String flowunit) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.