Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix typo and package name #834

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner November 2, 2023 14:30
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good.

@codecov-commenter
Copy link

Codecov Report

Merging #834 (df43802) into master (d04112a) will increase coverage by 0.08%.
The diff coverage is 32.25%.

@@             Coverage Diff              @@
##             master     #834      +/-   ##
============================================
+ Coverage     31.98%   32.06%   +0.08%     
- Complexity     4796     4815      +19     
============================================
  Files           703      703              
  Lines         69001    68999       -2     
  Branches       7854     7854              
============================================
+ Hits          22067    22127      +60     
+ Misses        45554    45491      -63     
- Partials       1380     1381       +1     
Files Coverage Δ
...stics/dataAnalysis/dataSmoothing/DataSmoother.java 97.05% <100.00%> (ø)
...mnSampleCreator/WettedWallColumnSampleCreator.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@EvenSol
Copy link
Collaborator

EvenSol commented Nov 3, 2023

seems fine. Suggest to merge to master.

@asmfstatoil asmfstatoil merged commit e5aa801 into equinor:master Nov 3, 2023
2 checks passed
@asmfstatoil asmfstatoil deleted the rename_datasmoother branch November 3, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants