Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ModelImageView a common component #92

Closed
mheggelund opened this issue Sep 19, 2023 · 0 comments · Fixed by #101
Closed

Make ModelImageView a common component #92

mheggelund opened this issue Sep 19, 2023 · 0 comments · Fixed by #101
Assignees
@mheggelund
Labels
good first issue Good for newcomers

Comments

@mheggelund
Copy link
Collaborator 

          Maybe we could make this a common component that we can re-use? (move to components folder and take image and text as prop). It doesn't seem to be domain specific. 😄

Originally posted by @olavis in #89 (comment)
@mheggelund mheggelund added the good first issue Good for newcomers label Sep 19, 2023
@mheggelund mheggelund mentioned this issue Sep 19, 2023
Merged
@olavis olavis changed the title Make common component. (move to components folder and take image and text as prop). Make ModelImageView a common component Sep 19, 2023
@mheggelund mheggelund self-assigned this Sep 21, 2023
@mheggelund mheggelund mentioned this issue Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mheggelund mheggelund

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore/image view component equinor/pepm-ui
1 participant
@mheggelund