Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/model page #89

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Feat/model page #89

merged 14 commits into from
Sep 19, 2023

Conversation

mheggelund
Copy link
Collaborator

Closes #61 closes #62

Copy link
Contributor

@olavis olavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments, but many of them can be resolved later in separate PRs. It's running and already an improvement compared to main, so I think we should fix what's most important and save the nitpicking for later. 😄

src/pages/Compute/Compute.tsx Outdated Show resolved Hide resolved
src/pages/Results/Results.tsx Outdated Show resolved Hide resolved
src/features/ModelView/ModelImageView/ModelImageView.tsx Outdated Show resolved Hide resolved
src/features/ModelView/ModelSourceView/ModelSourceView.tsx Outdated Show resolved Hide resolved
src/features/ModelView/ModelView.styled.tsx Outdated Show resolved Hide resolved
src/features/ModelView/ModelView.styled.tsx Show resolved Hide resolved
@mheggelund mheggelund merged commit 87276f1 into main Sep 19, 2023
1 check passed
@mheggelund mheggelund deleted the feat/model-page branch September 19, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants