Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Variogram result dialog size #399

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Fix: Variogram result dialog size #399

merged 4 commits into from
Dec 12, 2024

Conversation

o-jorgensen
Copy link
Contributor

@o-jorgensen o-jorgensen commented Dec 11, 2024 •
edited
Loading

  • Set a responsive size to the variogram slice dialog that works for results with and without all variogram models.
  • Add a loading indicator when the images are loading.
  • Add a custom text when variogram models are missing.
  • Make the close button more visible.

Experimental:
- Refactor the page to avoid repetition (used Claude AI, needs some developer eyes to verify)

Closes #398

@o-jorgensen o-jorgensen self-assigned this Dec 11, 2024
mheggelund
mheggelund approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@mheggelund mheggelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@o-jorgensen o-jorgensen merged commit 639cc05 into main Dec 12, 2024
5 checks passed
@o-jorgensen o-jorgensen deleted the fix/variogram-result-dialog-size branch December 12, 2024 09:48
@pepm-ci pepm-ci bot mentioned this pull request Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheggelund mheggelund mheggelund approved these changes

Assignees

@o-jorgensen o-jorgensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variogram slice dialog size
2 participants
@o-jorgensen @mheggelund