fix: Variogram results table size #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-jorgensen
commented
Dec 13, 2024
Comment on lines
+306
to
+317
| (isOwner ? ( | ||
| <Switch | ||
| onChange={(e: ChangeEvent<HTMLInputElement>) => { | ||
| updateStatus(e.target.checked, row.original); | ||
| }} | ||
| checked={checkedStatus(row.original)} | ||
| disabled={!isOwner} | ||
| ></Switch> | ||
| ) | ||
| /> | ||
| ) : ( | ||
| <Tooltip title="Only model owners can change the publish status"> | ||
| <Switch checked={checkedStatus(row.original)} disabled /> | ||
| </Tooltip> | ||
| )) |
There was a problem hiding this comment.
The point here was to not only disable the switch if isOwner is false, but to also wrap it in a Tooltip to explain why. Perhaps there is an easier way of doing it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #392
Example screenshot with the changes in this PR: