Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for gas-water #173

Closed
berland opened this issue Jun 5, 2020 · 1 comment · Fixed by #181
Closed

Support for gas-water #173

berland opened this issue Jun 5, 2020 · 1 comment · Fixed by #181

Comments

@berland
Copy link
Collaborator

berland commented Jun 5, 2020

Support for gas-water is needed.

Pyscal currently is built around the two classes WaterOil and GasOil, and can from these export the keywords used in gas-water, but probably dummy parameters for oil has to be present for this to work.

From the command line client pyscal, the two classes WaterOil and GasOil should not be visible (to the user), so if it is possible to use these to with dummy oil parameters, it should be ok. If that is not possible, consider writing a dedicated class GasWater (or WaterGas?) for this.
@berland
Copy link
Collaborator Author

berland commented Jun 5, 2020

See also #100

@berland berland mentioned this issue Jun 8, 2020
Open
@berland berland linked a pull request Jul 8, 2020 that will close this issue
Support gas-water #181
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support gas-water equinor/pyscal
1 participant
@berland