Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup.py with pyproject.toml #420

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Nov 17, 2023

Solves #419

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8c385b) 98.98% compared to head (86f1935) 98.98%.

❗ Current head 86f1935 differs from pull request most recent head 94de58a. Consider uploading reports for the commit 94de58a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files          16       16           
  Lines        2558     2558           
=======================================
  Hits         2532     2532           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alifbe alifbe requested a review from mferrera November 17, 2023 10:22
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! I'm approving so you can merge as needed but I think there are some things you could address if you wish

.github/workflows/pyscal.yml Outdated Show resolved Hide resolved
Comment on lines +11 to +12
[tool.setuptools]
packages = ["pyscal"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed because this repository isn't src/ based?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I was tempted to move pyscal folder inside src But decided to use this instead. Any other benefit of using src/ based?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/ is preferred I guess because it very clearly indicates where to click if you want to look at the source code. One of those conventions that is pretty standard around many languages; in my opinion it is the better option. I think some tools (setuptools in particular, in this case) look for it first.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll adopt this on next PR 👍

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
ci/testkomodo.sh Outdated Show resolved Hide resolved
@alifbe alifbe merged commit 22d82ef into equinor:main Nov 28, 2023
9 checks passed
@alifbe alifbe deleted the use-pyproject branch November 28, 2023 08:21
@alifbe alifbe mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants