-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace setup.py with pyproject.toml #420
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 16 16
Lines 2558 2558
=======================================
Hits 2532 2532
Misses 26 26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! I'm approving so you can merge as needed but I think there are some things you could address if you wish
[tool.setuptools] | ||
packages = ["pyscal"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed because this repository isn't src/
based?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. I was tempted to move pyscal
folder inside src
But decided to use this instead. Any other benefit of using src/
based?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/
is preferred I guess because it very clearly indicates where to click if you want to look at the source code. One of those conventions that is pretty standard around many languages; in my opinion it is the better option. I think some tools (setuptools in particular, in this case) look for it first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'll adopt this on next PR 👍
Solves #419