Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match SWINTEGERS and saturation print format #458

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

berland
Copy link
Collaborator

@berland berland commented Oct 2, 2024

The documentation for SWINTEGERS did not match the accuracy of printed
floating numbers, and this lead to a rare possibility for test failures,
exemplified by test_slgof.py::test_slgof_hypo where it was possible to
end up with two saturation points being printed identically.

The usage of SWINTEGERS in test code has been tuned accordingly.

Co-authored by: Alif Be <11570927+alifbe@users.noreply.github.com>

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (4162b12) to head (74b210b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          17       17           
  Lines        2725     2725           
=======================================
  Hits         2691     2691           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The documentation for SWINTEGERS did not match the accuracy of printed
floating numbers, and this lead to a rare possibility for test failures,
exemplified by test_slgof.py::test_slgof_hypo where it was possible to
end up with two saturation points being printed identically.

The usage of SWINTEGERS in test code has been tuned accordingly.

Co-authored by: Alif Be <11570927+alifbe@users.noreply.github.com>
@berland berland changed the title Inc swintegers Match SWINTEGERS and saturation print format Oct 2, 2024
@berland berland marked this pull request as ready for review October 2, 2024 10:07
@berland berland linked an issue Oct 2, 2024 that may be closed by this pull request
@alifbe alifbe self-requested a review October 2, 2024 10:45
Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I'll close the other PR since this seems to be a more general fix.

@berland berland merged commit 469bb84 into equinor:main Oct 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hypothesis test failure - test_slgof.py::test_slgof_hypo
3 participants