Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krowgend add to factory water_oil_gas #471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bartekvik
Copy link
Collaborator

This pull request proposes a solution for issue #455.

Issue The original issue reported that the current implementation of the WaterOilGas object did not allow for separate values of KROEND for water/oil and oil/gas systems. This is desirable in cases such as gas condensate systems and when oil moves into a gas cap. The issue includes examples and a figure to illustrate the problem.

Proposed solution The proposed solution is to accept both KROGEND (oil/gas) and KROWEND (water/oil) for the WaterOilGas object, then convert these into two separate KROEND and apply them to the respective WaterOil and OilGas objects. Thus, it does not affect anchoring of KROEND to critical and residual saturations. KROEND for WaterOil anchor to SWL, while KROEND GasOil anchor to SGCR=SGRO.
A test has been added to ensure this feature works.

Documentation No changes to the documentation have been made at this time. We will await approval of the proposed solution before updating the documentation.

@bartekvik bartekvik requested review from berland and alifbe November 26, 2024 12:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (ae09ae8) to head (62cf027).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   98.75%   98.76%           
=======================================
  Files          17       17           
  Lines        2725     2744   +19     
=======================================
+ Hits         2691     2710   +19     
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland
Copy link
Collaborator

berland commented Dec 4, 2024

Included in this PR there should be a corresonding update to the docs on https://equinor.github.io/pyscal/modelling.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants