Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom internal alias #999

Merged
merged 135 commits into from
Dec 18, 2023
Merged

Custom internal alias #999

merged 135 commits into from
Dec 18, 2023

Conversation

satr
Copy link
Contributor

@satr satr commented Dec 1, 2023

No description provided.

satr added 30 commits October 20, 2023 15:19
@satr
Added dns aliases types and crd
169bc64
@satr
Added dns aliases controller and handler bases
b5c16df
@satr
Merge remote-tracking branch 'origin/master' into custom-internal-alias
9cb596c
@satr
Extended dns aliases controller and handler, added appName to the Rad…
a298b10 
…ixDNSAlias
@satr
Added ingresses stubs to test
8b3bc04
@satr
Creating, updating RadixDNSAliases
8033711
@satr
Extended applicationconfig and RadixDNSAliases controllers
8ab98ac
@satr
Extended RadixDNSAliases controllers and handler, added ClusterConfig…
6e63dfb 
… and Radix constants
@satr
Extended RadixDNSAliases syncer
97aa2a1
@satr
Extended RadixDNSAliases syncer and handler, unit-tests, added cluste…
d8303b5 
…r config
@satr
Merge remote-tracking branch 'origin/master' into custom-internal-alias
fcb7d3d
@satr
Added config to syncers, added ingresses
9fafa24
@satr
Fixed unit-test
6211ea6
@satr
Added unit-test
be95c7a
@satr
Added unit-test, updating of an ingress port
a031561
@satr
Added unit-test for owner ref
d506fc9
@satr
Added unit-test for header
b1461a6
@satr
Updated unit-test for controller
f585e69
@satr
Updated unit-test for app controller
0917810
@satr
Updated unit-test for app controller
eceba1b
@satr
Handled changed, new a dn deleted aliases app-config
d8ead9b
@satr
Added unit-tests for dns aliases in app-config
eb3d087
@satr
Added port to the Radix DNS Alias
3f307aa
@satr
Update unit-tests
ca2d1e7
@satr
Merge remote-tracking branch 'origin/master' into custom-internal-alias
c32cb0d 
# Conflicts:
#	pkg/apis/utils/application_builder.go
@satr
Update unit-tests
7ba6fd8
@satr
Added DNS alias validation
c8619e1
@satr
Added DNS alias validation tests. Removed dot from validation of reso…
aca8f6b 
…urces
@satr
Extended DNS alias validation
fd2a696
@satr
Added validation on existing RadixDNSAliases on applying RadixApplica…
641901b 
…tion
nilsgstrabo
nilsgstrabo requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some new comments, and some of the previous comments are still unresolved.
Could you also update radix-common module to latest version.

@Richard87 Richard87 mentioned this pull request Dec 15, 2023
Closed
@satr satr requested a review from nilsgstrabo December 18, 2023 11:21
@satr satr merged commit 8c00555 into master Dec 18, 2023
4 checks passed
@satr satr deleted the custom-internal-alias branch December 18, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsgstrabo nilsgstrabo nilsgstrabo approved these changes

Assignees

@satr satr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satr @nilsgstrabo