Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform custom resources #1160

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Terraform custom resources #1160

merged 9 commits into from
Jan 29, 2024

Conversation

sveinpj
Copy link
Collaborator

@sveinpj sveinpj commented Jan 29, 2024

No description provided.

@sveinpj sveinpj requested a review from Richard87 January 29, 2024 12:19
@Richard87
Copy link
Contributor

image

Me sko gjort någe med workflowen 🤔

Richard87
Richard87 requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add subscription_id to all azurerm providers and backends (and to terraform_remote_state backends)
  • remove client_id?
  • add summary-extmon.sh

terraform/subscriptions/s940/extmon/clusters/backend.tf Show resolved Hide resolved
terraform/subscriptions/s940/extmon/clusters/backend.tf Outdated Show resolved Hide resolved
@sveinpj sveinpj requested a review from Richard87 January 29, 2024 14:27
@sveinpj sveinpj merged commit 1b4fdcf into master Jan 29, 2024
4 checks passed
@sveinpj sveinpj deleted the terraform-custom-resources branch January 29, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Richard87 Richard87 Richard87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveinpj @Richard87