Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interp_relperm] Add support for family 2 output #382

Merged
merged 2 commits into from
May 31, 2021

Conversation

berland
Copy link
Collaborator

@berland berland commented May 28, 2021

The two commits should be reviewed independently, and merged, not squashed.

Support for family 2 input is a different PR.

@berland berland requested a review from eivindsm May 28, 2021 09:09
@codecov-commenter
Copy link

Codecov Report

Merging #382 (5b8a3d2) into master (e4edb03) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   85.47%   85.45%   -0.02%     
==========================================
  Files          42       42              
  Lines        6107     6107              
==========================================
- Hits         5220     5219       -1     
- Misses        887      888       +1     
Impacted Files Coverage Δ
src/subscript/interp_relperm/interp_relperm.py 82.16% <91.66%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4edb03...5b8a3d2. Read the comment docs.

Copy link
Contributor

@eivindsm eivindsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pr looks good. The possible combinations of saturation kws for family ii is quite extensive. For family i the script requires both SWOF and SGOF to be present, have you considered how to implement the similar requirement for family ii? Eg all possible combinations of SWFN, SGFN, SGWFN, SOF2, SOF3, SOF32D, SWF3, SGF3, SOF3 (IKU3P and ODD3P options)

@berland
Copy link
Collaborator Author

berland commented May 28, 2021

See equinor/pyscal#100

Those keywords are not supported by pyscal but can be added. The more advanced keywords are not planned to be supported by pyscal.

Copy link
Contributor

@eivindsm eivindsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berland berland merged commit 44ae966 into equinor:master May 31, 2021
@berland berland deleted the interp_relperm_fam2 branch June 21, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants