Skip to content

Commit

Permalink
Not use new pip resolver (#349)
Browse files Browse the repository at this point in the history
  • Loading branch information
asnyv authored Nov 26, 2020
1 parent 2ffefad commit 879b078
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/webviz-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,14 @@ jobs:
- name: 📦 Install webviz-config with dependencies
run: |
pip install --upgrade pip wheel
pip install --use-feature=2020-resolver . 'pandas==${{ matrix.pandas-version }}'
pip install 'pandas==${{ matrix.pandas-version }}'
pip install --upgrade pip
pip install .
- name: 📦 Install test dependencies
run: |
pip install --use-feature=2020-resolver .[tests]
pip install .[tests]
pip install dash[testing]
wget https://chromedriver.storage.googleapis.com/$(wget https://chromedriver.storage.googleapis.com/LATEST_RELEASE -q -O -)/chromedriver_linux64.zip
unzip chromedriver_linux64.zip
Expand Down
18 changes: 11 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ title: Simple Webviz example
pages:

- title: Front page
content:
content:
- ExamplePlugin:
```
Expand Down Expand Up @@ -181,7 +181,7 @@ def _user_download_data(data_requested):
}
if data_requested
else None
)
)
```

By letting the plugin define the callback, the plugin author is able
Expand Down Expand Up @@ -232,7 +232,7 @@ title: Simple Webviz example
pages:
- title: Front page
content:
content:
- ExamplePlugin:
title: My special title
```
Expand Down Expand Up @@ -265,7 +265,7 @@ title: Simple Webviz example
pages:
- title: Front page
content:
content:
- ExamplePlugin:
title: My special title
number: Some text instead of number
Expand Down Expand Up @@ -379,7 +379,7 @@ webviz build some_config.yaml --portable /some/outputfolder

The core of `webviz-config` will do the following:

1) If the user has *not* asked for a portable version (i.e. not given the
1) If the user has *not* asked for a portable version (i.e. not given the
`--portable` command line argument, the decorator `@webvizstore` will
not change the attached function.
2) If the user asks for a portable version, it will
Expand Down Expand Up @@ -409,7 +409,7 @@ has a `__repr__` function associated with it such that instances representing
different input also have different string output from `__repr__`.

> :rocket: If you nest decorations, e.g. use both `@webvizstore` and
`@CACHE.memoize`, following the same order as in the example above usually gives
`@CACHE.memoize`, following the same order as in the example above usually gives
best performance.

### Common settings
Expand Down Expand Up @@ -495,7 +495,7 @@ title: Simple Webviz example
pages:

- title: Front page
content:
content:
- ourmodule.OurCustomPlugin:
title: Title of my custom plugin
```
Expand All @@ -515,7 +515,11 @@ To run tests it is necessary to first install the [selenium chrome driver](https
Then install the Python development requirements:
```bash
pip install .[tests]
pip install dash[testing]
```
The second of these commands appears to be necessary as long as
[this `pip` issue is open](https://github.com/pypa/pip/issues/4957).

You can then run the tests using
```bash
pytest tests --forked
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def get_long_description() -> str:
TESTS_REQUIRES = [
"bandit",
"black",
"dash[testing]",
"jsonschema",
"mock",
"mypy",
Expand Down

0 comments on commit 879b078

Please sign in to comment.