Skip to content

Commit

Permalink
Fix flaky test on self-hosted runner
Browse files Browse the repository at this point in the history
One of the Selenium tests on a plot axis title was sometimes
timing out. This change doubles the timeout to 20s. For sure,
10s already seems long; if there's still an issue it may be
another problem.
  • Loading branch information
kwinkunks committed Mar 1, 2023
1 parent 229ae3c commit ecc3ad2
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tests/views/test_response_correlation.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ def test_axes_labels(mock_data, dash_duo):

plot_id = plugin.uuid("response-overview")

# check that y axis label spells out "Value"
dash_duo.wait_for_text_to_equal(f"#{plot_id} text.ytitle", "Value")
# check that y axis label spells out "Value"; test is flaky so longer
# timeout.
dash_duo.wait_for_text_to_equal(f"#{plot_id} text.ytitle", "Value", timeout=20)

# check that one has date, the other has index as x axis label
if wanted_response == "FOPR":
Expand Down

0 comments on commit ecc3ad2

Please sign in to comment.