Pin urllib3 < 2 #443
Merged
Pin urllib3 < 2 #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, in the github action workflow that tests webviz-ert, urllib3 is already pinned, but |
I guess it is because the new version is installed through a dependency when installing webviz-ert, and by pinning it this should now be solved? Or am i thinking wrong here? |
|
Some test dependency must install a newer version then? |
i.e selenium uses requests which uses urllib3 - so i guess it is pulled down when running the tests. Updated the PR to add the pinning there instead. |
oysteoh
force-pushed
the
pin_urllib3
branch
2 times, most recently
from
258df14 to
fd67a23
Compare
urllib3 needs to be pinned below v2 due to incompabilites with RHEL7
oyvindeide
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib3 needs to be pinned below v2 due to incompabilites with RHEL7