Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dropdown grouping more explicit #816

Open
Anders2303 opened this issue Nov 28, 2024 · 0 comments
Open

Make Dropdown grouping more explicit #816

Anders2303 opened this issue Nov 28, 2024 · 0 comments
Labels
enhancement New feature or request small issue

Comments

@Anders2303
Copy link
Collaborator

PR #794 introduced a feature in Dropdown that allows you to group dropdown-options together under a label in the scroll-menu. How-ever, the current approach does not guarantee that options of the same group are shown together if the options array is not properly sorted before-hand, making implementation cumbersome and less intuitive.

As suggested by @rubenthoms in #794 (comment), we should consider having two types of options - e.g. DropdownOption and DropdownGroup, where the group wraps a list of options.

Naturally, this issue is only relevant if #794 is merged, but this issue should be prioritized before too many implementations make use of the current solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small issue
Projects
None yet
Development

No branches or pull requests

1 participant