Implement Well-log viewer module MVP #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supports continuous curves from SSDL endpoint * Settings are persisted across reloads
31 tasks
rubenthoms
requested changes
Nov 22, 2024
frontend/src/modules/WellLogViewer/view/SubsurfaceLogViewerWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellLogViewer/view/SubsurfaceLogViewerWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellLogViewer/view/SubsurfaceLogViewerWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellLogViewer/view/SubsurfaceLogViewerWrapper.tsx
Outdated
Show resolved
Hide resolved
rubenthoms
approved these changes
Dec 3, 2024
| }); | ||
|
|
||
| // TODO, do an offsett or something, so they dont always start on the same color? | ||
| const colorSet = React.useRef<ColorSet>(new ColorSet(CURVE_COLOR_PALETTE)); |
There was a problem hiding this comment.
Could this be a constant outside this function?
There was a problem hiding this comment.
Sure, originally wanted each track to maintain their own internal color iteration, but it actually makes more sense that they all take from the same instance; that way, colors dont repeat as you add tracks and plots (unless you loop the entire palette, of course)
| <Dropdown | ||
| value={props.plot.type} | ||
| options={PLOT_TYPE_OPTIONS} | ||
| onChange={(v) => handlePlotChange({ type: v as TemplatePlotTypes })} |
There was a problem hiding this comment.
as TemplatePlotTypes does not seem to be necessary.
There was a problem hiding this comment.
Yes. Also could get rid of the one used on "addPlot" aswell, just needed to update the AddItemButton comp to pass the type
...lLogViewer/settings/components/TemplateTrackSettings/private-components/SortablePlotList.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellLogViewer/view/components/SubsurfaceLogViewerWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellLogViewer/view/components/SubsurfaceLogViewerWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/src/modules/WellLogViewer/view/components/SubsurfaceLogViewerWrapper.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is equivalent to #702; this is copy-branch to resolve some stuff that broke during some rebases
Branch dependencies
This uses the readout box and sortable list components introduced in other PRs, those should be reviewed and merged first
SortableListcomponent (+ sub components) and menu utility components #685(Partially) resolves issue #683
Adds a wrapper module for the Subsurface WellLogViewer component. The component renders out well-log data along a given wellbore's MD/TVD values. Note that this implementation is a simpler MVP, an is therefore not feature-complete; more features will be introduced in separate PRs.
Features:
well/log_curve_dataandwell/wellbore_log_curve_headersAPI endpointFuture Work